This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Set _isSeeking in seekBySeconds even when _hasEnded is set #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -356,6 +356,7 @@ package com.videojs.providers{ | |||
| } | |||
| else if(_hasEnded) | |||
| { | |||
| _isSeeking = true; | |||
There was a problem hiding this comment.
Seems like this should be pulled up out of the branches of these conditionals entirely.
There was a problem hiding this comment.
@imbcmdth pointed out to me that both branches have conditions which may not be mutually exclusive.
dmlap
added a commit
that referenced
this pull request
Nov 6, 2015
Set _isSeeking in seekBySeconds even when _hasEnded is set
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were in a situation where if
endOfStreamwas called (setting_hasEndedto true) and then we tried to replay by seeking to time 0, we wouldn't notify the player that seek had ended and the spinner would continue to show and playback would be broken until it timed out.