This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
fix muting video before play (muted on the video element) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to include the built swf (we should probably just gitignore it), we'll rebuild it when deploying. |
| @@ -128,6 +128,10 @@ package{ | |||
| _app.model.preload = String(loaderInfo.parameters.preload); | |||
| } | |||
|
|
|||
| if(loaderInfo.parameters.muted != undefined){ | |||
| _app.model.muted = loaderInfo.parameters.muted; | |||
There was a problem hiding this comment.
this basically loads in the muted attribute value when set? I can't believe that we this was the issue, lol.
|
LGTM |
|
Should I just git rm the |
|
@brandonocasey just remove the |
|
@dmlap guess I committed it again when I added the if check for loop, I fixed it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuild swf for change