feat: deprecate the use of starttime in player.js (#3838)

brandonocasey · gkatsev · commit 22cf3dd935de · 2016-12-21T14:23:00.000-05:00
diff --git a/src/js/player.js b/src/js/player.js
@@ -1250,12 +1250,14 @@ class Player extends Component {
    *
    * @fires Player#firstplay
    * @listens Tech#firstplay
+   * @deprecated As of 6.0 passing the `starttime` option to the player will be deprecated
    * @private
    */
   handleTechFirstPlay_() {
     // If the first starttime attribute is specified
     // then we will start at the given offset in seconds
     if (this.options_.starttime) {
+      log.warn('Passing the `starttime` option to the player will be deprecated in 6.0');
       this.currentTime(this.options_.starttime);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1250,12 +1250,14 @@ class Player extends Component {`
`1250`	`1250`	`*`
`1251`	`1251`	`* @fires Player#firstplay`
`1252`	`1252`	`* @listens Tech#firstplay`
	`1253`	+ * @deprecated As of 6.0 passing the `starttime` option to the player will be deprecated
`1253`	`1254`	`* @private`
`1254`	`1255`	`*/`
`1255`	`1256`	`handleTechFirstPlay_() {`
`1256`	`1257`	`// If the first starttime attribute is specified`
`1257`	`1258`	`// then we will start at the given offset in seconds`
`1258`	`1259`	`if (this.options_.starttime) {`
	`1260`	+ log.warn('Passing the `starttime` option to the player will be deprecated in 6.0');
`1259`	`1261`	`this.currentTime(this.options_.starttime);`
`1260`	`1262`	`}`
`1261`	`1263`