Skip to content

Commit 245efac

Browse files
authored
fix(tech): add abstract crossOrigin method on Tech (#6765)
As part of #6588, we started using the crossOrigin method. However, it's possible that a tech doesn't support this. Notably, the Flash tech. We should instead have an abstract method on Tech that returns nothing so we don't fail on those browsers.
1 parent d4430a3 commit 245efac

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

src/js/tech/tech.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,25 @@ class Tech extends Component {
430430
*/
431431
reset() {}
432432

433+
/**
434+
* Get the value of `crossOrigin` from the tech.
435+
*
436+
* @abstract
437+
*
438+
* @see {Html5#crossOrigin}
439+
*/
440+
crossOrigin() {}
441+
442+
/**
443+
* Set the value of `crossOrigin` on the tech.
444+
*
445+
* @abstract
446+
*
447+
* @param {string} crossOrigin the crossOrigin value
448+
* @see {Html5#setCrossOrigin}
449+
*/
450+
setCrossOrigin() {}
451+
433452
/**
434453
* Get or set an error on the Tech.
435454
*

0 commit comments

Comments
 (0)