Skip to content

Commit

Permalink
docs: Expand testing info in CONTRIBUTING.md (#4020)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinlitchfield authored and brandonocasey committed Feb 2, 2017
1 parent 6ad1e5c commit 2da4e76
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -140,13 +140,17 @@ npm install
#### Running tests

To run the tests all you need to do is run
Tests can be run either from the shell or from the browser.

To run the tests from the shell, just run

```sh
npm test
```

This will build video.js locally and run the tests using [Karma](https://karma-runner.github.io/1.0/index.html) which runs our tests in actual browsers.
This will build video.js locally and run the test suite using [Karma](https://karma-runner.github.io/1.0/index.html), which runs our tests in actual browsers.

To run tests from the browser, first start a local server with `npm start` (this also watches for changes and rebuilds video.js and the test files as necessary). Then navigate to `http://localhost:9999/test`, and you'll see a page that displays the results of all the tests. To rerun the tests after making changes, just refresh the page. To run an individual test, click the "Rerun" link next to the test's title.

#### Building videojs

Expand Down Expand Up @@ -275,6 +279,8 @@ Tests attached to bug fixes should fail before the change and succeed with it.
npm test
```

See [Running tests](#running-tests) for more information.

#### Step 6: Push

```sh
Expand Down

0 comments on commit 2da4e76

Please sign in to comment.