Skip to content

Commit dfcfa45

Browse files
syranezgkatsev
authored andcommitted
fix(TextTrackSetting): Do not use default button type. (#5512)
The default button type is "submit" which triggers a form submit. Thus if videojs is embedded in a form element the button triggers a form submit. This is the same problem with same solution as discussed in #2470
1 parent 46e3ef0 commit dfcfa45

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/js/tracks/text-track-settings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,11 +464,11 @@ class TextTrackSettings extends ModalDialog {
464464
return createEl('div', {
465465
className: 'vjs-track-settings-controls',
466466
innerHTML: [
467-
`<button class="vjs-default-button" title="${defaultsDescription}">`,
467+
`<button type="button" class="vjs-default-button" title="${defaultsDescription}">`,
468468
this.localize('Reset'),
469469
`<span class="vjs-control-text"> ${defaultsDescription}</span>`,
470470
'</button>',
471-
`<button class="vjs-done-button">${this.localize('Done')}</button>`
471+
`<button type="button" class="vjs-done-button">${this.localize('Done')}</button>`
472472
].join('')
473473
});
474474
}

0 commit comments

Comments
 (0)