Skip to content

Commit fe760a4

Browse files
committed
fix: remove unnecessary comments from video.min.js (#3709)
This involves updating to latest version of uglify and setting "screwIE8" to false since that is a default in 2.7. However, this makes "preserveComments" "some" work as it is supposed to work. Fixes #3707. This also comes from the stable branch after the 5.11.9 release.
1 parent 49e29ba commit fe760a4

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@
8787
* @gkatsev added tests for webpack and browserify bundling and node.js requiring ([view](https://github.com/videojs/video.js/pull/3558))
8888
* @rlchung fixed tests that weren't disposing players when they finished ([view](https://github.com/videojs/video.js/pull/3524))
8989

90+
## 5.11.9 (2016-10-25)
91+
* greenkeeper updated karma dependencies ([view](https://github.com/videojs/video.js/pull/3523))
92+
* update to latest uglify to fix preserve comments issue. Disable screw ie8 option. ([view](https://github.com/videojs/video.js/pull/3709))
93+
* remove sourcemap generation ([view](https://github.com/videojs/video.js/pull/3710))
94+
9095
## 5.11.8 (2016-10-17)
9196
* @misteroneill restore timeupdate/loadedmetadata listeners for duration display ([view](https://github.com/videojs/video.js/pull/3682))
9297

build/grunt.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ module.exports = function(grunt) {
105105
uglify: {
106106
options: {
107107
preserveComments: 'some',
108+
screwIE8: false,
108109
mangle: true,
109110
compress: {
110111
sequences: true,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"grunt-contrib-connect": "~0.7.1",
7575
"grunt-contrib-copy": "^0.8.0",
7676
"grunt-contrib-cssmin": "~1.0.2",
77-
"grunt-contrib-uglify": "~0.11.0",
77+
"grunt-contrib-uglify": "^2.0.0",
7878
"grunt-contrib-watch": "~0.1.4",
7979
"grunt-coveralls": "^1.0.0",
8080
"grunt-fastly": "^0.1.3",

0 commit comments

Comments
 (0)