Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove un-needed contructor and function overrides #3721

Merged
merged 1 commit into from
Nov 4, 2016
Merged

remove un-needed contructor and function overrides #3721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/js/big-play-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ import Component from './component.js';
*/
class BigPlayButton extends Button {

constructor(player, options) {
super(player, options);
}

/**
* Allow sub components to stack CSS class names
*
Expand Down
4 changes: 0 additions & 4 deletions src/js/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ import assign from 'object.assign';
*/
class Button extends ClickableComponent {

constructor(player, options) {
super(player, options);
}

/**
* Create the component's DOM element
*
Expand Down
20 changes: 0 additions & 20 deletions src/js/clickable-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,26 +117,6 @@ class ClickableComponent extends Component {
return `vjs-control vjs-button ${super.buildCSSClass()}`;
}

/**
* Adds a child component inside this clickable-component
*
* @param {String|Component} child The class name or instance of a child to add
* @param {Object=} options Options, including options to be passed to children of the child.
* @return {Component} The child component (created by this process if a string was used)
* @method addChild
*/
addChild(child, options = {}) {
// TODO: Fix adding an actionable child to a ClickableComponent; currently
// it will cause issues with assistive technology (e.g. screen readers)
// which support ARIA, since an element with role="button" cannot have
// actionable child elements.

// let className = this.constructor.name;
// log.warn(`Adding a child to a ClickableComponent (${className}) can cause issues with assistive technology which supports ARIA, since an element with role="button" cannot have actionable child elements.`);

return super.addChild(child, options);
}

/**
* Enable the component element
*
Expand Down