Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report errors during linting in the build process, not warnings #4041

Merged

Conversation

OwenEdwards
Copy link
Member

Description

If linting fails during the grunt build process, the console messages only show any warnings that were reported, not the error that caused the failure. That's really unhelpful for people who don't know this feature!

Specific Changes proposed

Change the lint parameters in build/grunt.js so that only errors are reported. (In the future we can bring back warnings, or provide a different way to build and display warnings.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix - N/A
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev merged commit 6208e4b into videojs:master Feb 8, 2017
@OwenEdwards OwenEdwards deleted the fix/vjsstandard-only-show-errors branch March 4, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants