fix: cap log history at 1000 items #6192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Aug 29, 2019
src/js/utils/create-logger.js
Outdated
| @@ -33,6 +33,11 @@ const LogByTypeFactory = (name, log) => (type, level, args) => { | |||
| // Add a clone of the args at this point to history. | |||
| if (history) { | |||
| history.push([].concat(args)); | |||
|
|
|||
| // remove old history | |||
| while (history.length > 1000) { | |||
There was a problem hiding this comment.
would something like history = history.slice(-1000) work? Theoretically, should be faster as well, since we won't be shifting the entire list n times.
There was a problem hiding this comment.
makes sense to me
gkatsev
approved these changes
Aug 29, 2019
gkatsev
added
confirmed
minor
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cap log history at 1000 items to prevent running out of memory on long videos.