Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: turn on strict mode again #6334

Merged
merged 2 commits into from
Dec 2, 2019
Merged

fix: turn on strict mode again #6334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ecabb
remove strict:false from rollup config
gkatsev Nov 26, 2019
41bad07
features properties should be settable
gkatsev Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ export default cliargs => [
format: 'umd',
file: 'dist/video.js',
name: 'videojs',
strict: false,
banner,
globals: globals.browser
},
Expand All @@ -136,13 +135,11 @@ export default cliargs => [
{
format: 'es',
file: 'dist/video.es.js',
strict: false,
banner,
globals: globals.module
}, {
format: 'cjs',
file: 'dist/video.cjs.js',
strict: false,
banner,
globals: globals.module
}
Expand All @@ -167,7 +164,6 @@ export default cliargs => [
format: 'umd',
file: 'dist/alt/video.novtt.js',
name: 'videojs',
strict: false,
banner: compiledLicense(Object.assign({includesVtt: true}, bannerData)),
globals: globals.browser
},
Expand All @@ -193,13 +189,11 @@ export default cliargs => [
{
format: 'es',
file: 'core.es.js',
strict: false,
banner,
globals: globals.module
}, {
format: 'cjs',
file: 'core.js',
strict: false,
banner,
globals: globals.module
}
Expand All @@ -220,7 +214,6 @@ export default cliargs => [
format: 'umd',
name: 'videojs',
file: 'dist/alt/video.core.js',
strict: false,
banner,
globals: globals.browser
},
Expand All @@ -242,7 +235,6 @@ export default cliargs => [
format: 'umd',
name: 'videojs',
file: 'dist/alt/video.core.novtt.js',
strict: false,
banner: compiledLicense(Object.assign({includesVtt: true}, bannerData)),
globals: globals.browser
},
Expand Down
2 changes: 1 addition & 1 deletion src/js/tech/html5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ Html5.Events = [
['featuresNativeVideoTracks', 'supportsNativeVideoTracks'],
['featuresNativeAudioTracks', 'supportsNativeAudioTracks']
].forEach(function([key, fn]) {
defineLazyProperty(Html5.prototype, key, () => Html5[fn](), false);
defineLazyProperty(Html5.prototype, key, () => Html5[fn](), true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last property here was used to see whether we should create a setter for the property or not. Given that these values do change, particularly with text tracks, we do want these to be settable but because we weren't using strict mode, it was being set without a problem. Instead, we should just make sure these are settable.

});

/**
Expand Down