Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 180 projection #172

Merged
merged 1 commit into from
Aug 13, 2019
Merged

add 180 projection #172

merged 1 commit into from
Aug 13, 2019

Conversation

luiscerqueira
Copy link
Contributor

Description

Reference to #36

Added support for 180Vr video as an enhancement.

Specific Changes proposed

  • Updated the plugin.js by adding a condition if the projection equals 180 and added the logic to map the texture of the video to it.
  • Added condition for orbit-orientation-controls.js to limit minimum and maximum rotation if the projection is half of the view
  • Added 180 to the validProjections array in the utils.js file
  • Added example page 180.html
  • Index.html updated with a link to 180 example page
  • Added a 180 Vr sample video in the samples folder

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@luiscerqueira luiscerqueira mentioned this pull request Feb 19, 2019
@blurymind
Copy link

very cool! Hope this gets merged :) 👍

@brandonocasey brandonocasey merged commit 67fe78b into videojs:master Aug 13, 2019
@axten
Copy link

axten commented Aug 19, 2019

cool feature! are there any plans to file a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants