fix: add a cardboard button for native webvr support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -523,6 +523,10 @@ class VR extends Plugin { | |||
| this.log('WebVR supported, VRDisplays found.'); | |||
| this.vrDisplay = displays[0]; | |||
| this.log(this.vrDisplay); | |||
|
|
|||
There was a problem hiding this comment.
Could be good to add a comment here about checking for native vr displays
brandonocasey
approved these changes
Aug 17, 2017
mister-ben
pushed a commit
to mister-ben/videojs-vr
that referenced
this pull request
Dec 4, 2023
chore: Swap webvr for webxr polyfill packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, firefox 55 on win 10 with a Vive.
This addresses #14 as well.