Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly check for cardboard button on control bar so we don't … #26

Merged
merged 1 commit into from
Aug 24, 2017
Merged

fix: correctly check for cardboard button on control bar so we don't … #26

merged 1 commit into from
Aug 24, 2017

Conversation

brandonocasey
Copy link
Contributor

…add two

gkatsev
gkatsev approved these changes Aug 23, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I thought this was going to be the case when @jbroberg mentioned the issue.

LGTM.

@brandonocasey brandonocasey merged commit 9184472 into master Aug 24, 2017
@gkatsev gkatsev deleted the fix/double-cardboard-button branch August 24, 2017 18:34
mister-ben pushed a commit to mister-ben/videojs-vr that referenced this pull request Dec 4, 2023
@kevleyski
Merge pull request videojs#26 from kevleyski/main
ad1b413 
chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap better precision for headsets)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev