Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Style blocks #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WIP: Style blocks #35

wants to merge 3 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Mar 4, 2019

Expects a standalone version of css and then requires the integration to pass parser.styles into processCues, but this still needs to be updated.

TODO:

  • STYLE blocks
  • can't have style blocks once seen cues
  • filter allowed properties
  • classes
  • webvtt object
    • voice
    • italics
    • bold
    • underline
    • ruby
    • ruby text
    • language
    • other objects

@gjanblaszczyk
Copy link
Member

Hi Gary, What is the status of this PR? Are you planning to continue work on this PR this year?

@gkatsev
Copy link
Member Author

gkatsev commented Mar 4, 2020

Yes, I'd like to get this done some time this year, though, it likely needs to be re-done based on the refactor in master. Another thing is to decide what to do about the parsing of the CSS. I don't want to include it by default. Also, not sure if the css package is the best thing for this or if there's something better/lighter to use.
Also, I would say that the regions work is likely a higher priority for me, especially since Chrome is working on native support for this finally.

Base automatically changed from master to main January 22, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants