Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent test failures #11

Closed
kmalakoff opened this issue May 21, 2014 · 2 comments
Closed

Fix intermittent test failures #11

kmalakoff opened this issue May 21, 2014 · 2 comments

Comments

@kmalakoff
Copy link
Member

Two hypotheses:

  1. they are due to test setup and cleanup not being perfect when option variants are being run one after another

  2. they are due to a sequence returning incorrectly like MemoryCursor.buildFindQuery needing to merge query parameters

  1) hasMany (cache: undefined, query_cache: undefined, embed: true) Can manually delete a relationship by related_model (belongsTo) with unloaded model:
     Uncaught AssertionError: loaded correct model

  2) hasMany (cache: undefined, query_cache: undefined, embed: true) Can manually delete a relationship by array of related_model (belongsTo) with unloaded model:
     Uncaught AssertionError: loaded correct model

  3) hasMany (cache: undefined, query_cache: undefined, embed: true) Can query on related (one-way hasMany) models with included relations:
     Uncaught AssertionError: found model
@forivall
Copy link
Contributor

solution 1 was implemented and needs to be double checked that this problem is fixed

@forivall forivall reopened this Jul 16, 2014
@forivall
Copy link
Contributor

Actually fixed; travis tests passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants