-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Process #2
Comments
Hi, the default CMakeLists currently has significant issues with enabling Best regards, Namik On Sun, Jun 29, 2014 at 8:09 PM, matusi143 notifications@github.com wrote:
|
Hi, According to the FindOpenCL.cmake, it should work either if: Personally, I've been using symbolic links to handle OpenCL Philippe 2014-06-30 0:12 GMT+02:00 Namik Karovic notifications@github.com:
|
Namik, thank you for the update. I will wait for the next version. Do you plan on offering an interim release that will build so people can see the UI and offer feedback on the matrix market interface when that becomes available? Phillipe, I am using Windows 8.1 so /usr won't work. Do you know how I can modify my %PATH to allow OPENCLROOT to work or is that Linux only as well? |
Hi, I think it has nothing to do with the %PATH. You probably need to set the If the environment variable OPENCLROOT is not set, the CMake script uses Philipe 2014-06-30 2:25 GMT+02:00 matusi143 notifications@github.com:
|
Philippe is right, this is all set through the environment variables in Windows, as this is the only way to automatically detect an OpenCL SDK. Have a look here: http://superuser.com/questions/502358/easier-way-to-change-environment-variables-in-windows-8 |
Hi, I already tried setting OPENCLROOT, but it yielded the same results as any I get a couple of these: error: multiple definition of I have no idea what causes this. Namik On Mon, Jun 30, 2014 at 12:12 PM, PhilippeTillet notifications@github.com
|
The problem with double_float_conversion_program is fixed here: |
Quick update, It seems that the errors I mentioned appear only in the benchmark_solver. As for what I did to enable OpenCL: I'll update the CMakeLists file and Readme to better describe the build Regards, Namik On Mon, Jun 30, 2014 at 12:31 PM, Namik Karovic namik.karovic@gmail.com
|
Hi,
This reminded me that I haven't updated my local ViennaCL repo for quite
These new errors seem oddly familiar, but I don't know what needs to be Namik On Mon, Jun 30, 2014 at 12:42 PM, Namik Karovic namik.karovic@gmail.com
|
Hi Namik, Can you reset before my Sat Jun 28th commit and retry? I pushed some big Philippe 2014-06-30 13:30 GMT+02:00 Namik Karovic notifications@github.com:
|
Thanks guys. I'll synch things up and test this tonight. Should I be using the dev version of VIennaCL rather than 1.5.2? If so, should I be looking at June 27th image on github? I'm using the AMD 2.9 SDK installed to its default directory. I will check out my env variables later when I get back to my test computer. |
Hi, The current dev version works fine under Clang and GCC. You're more than Philippe 2014-06-30 14:09 GMT+02:00 matusi143 notifications@github.com:
|
changes, which have not yet been tested on windows. Philippe, thanks for the hint. I made a local temporary ViennaCL branch Many thanks for the help, Namik On Mon, Jun 30, 2014 at 2:09 PM, matusi143 notifications@github.com wrote:
|
Namik, Much progress, however, I am now encountering the following error in CMake: Boost version: 1.56.0 Could not find a package configuration file provided by "OpenCL" with any
Add the installation prefix of "OpenCL" to CMAKE_PREFIX_PATH or set I had a ton of qt5 errors but I was able to find those files and get past them by manually entering them. For example: C:\Qt\5.3\msvc2013_64\lib\cmake\Qt5Quick Unfortunately, it looks like OpenCLConfig.cmake should be part of the benchmark-gui and perhaps it is not checked into the repository. Any help would be greatly appreciated. Thanks, |
Phillipe, Thank you, setting my boost_root and OPENCLROOT to the appropriate directories in the environmental variables worked well. Trying to build the latest version of viennacl in cmake was a long process in manually finding files but ultimately worked pretty well. As the release gets closer, please let me know and I will test the process on Windows 8.1, CMake 3.0 and 2.8.11.2 with VS2013. Thanks, |
The build errors on Visual Studio with the latest tip of viennacl-dev should be fixed here: viennacl/viennacl-dev@2582f9b |
Karl, Thank you, the CMake for viennacl-dev as well as the compile with VS2013 now runs well. There are a bunch of warning as you mentioned. Thank you, as always, for the quick turnaround! -Matt |
Namik, I am still having trouble using CMake with viennacl-benchmark-gui. I will repost my message from a couple days ago for reference. Thanks, Boost version: 1.56.0 Could not find a package configuration file provided by "OpenCL" with any OpenCLConfig.cmake Add the installation prefix of "OpenCL" to CMAKE_PREFIX_PATH or set |
Matthew, I guess you didn't notice I updated the Readme file to better describe First you need to make sure your CMake has the FindOpenCL module. The error Also take care that OPENCLROOT variable is set ( I guess you've done this That's all that needs to be done, as far as I know. Best regards, On Wed, Jul 2, 2014 at 7:03 PM, Matthew Musto notifications@github.com
|
Thanks for looking into this, Namik. I think we can also use the same approach here as for viennacl-dev and just hold the FindOpenCL.cmake separately. I'll play with this (hopefully) tomorrow. |
Namik, Thank you. I had not checked the readme file again. Moving that file allowed CMake to complete. I'm still running into some warning with CMake and ultimately the build in VS2013 didn't work perfectly but I want to spend some time with it first before bothering any of you guys with it. Thanks again! |
Namik, I mentioned I was still having issues building on VS2013 and I have been unable to easily solve it. Here is the error I am getting. 👎 error: D8021 : invalid numeric argument '/Wno-unused-local-typedefs' Output: Commenting out: #Disable unused warnings that come from Boost and QCustomPlot Did not make any difference. It appears you were trying to suppress that warning anyway. Any help would be greatly appreciated. Thanks, |
Hi Matthew, I really can't say what is causing these errors. My guess is something's Regards, Namik |
Hey Matthey, |
CMake is running well now. Still a few nits with the output still inserting gcc specific compiler flags. How best do you want me report those issues? Or rather, should I just submit a fix in the git repository for review and possible acceptance? |
@matusi143 : I just promoted you to collaborator, so feel free to commit 'trivial' fixes directly. For changes which you're not confident about (maybe os-specific, compiler-specific, etc.), please commit them to a new branch and issue a pull request so that we can first check them. Thanks a lot for your contributions :-) |
@karlrupp : Thank you :-) I will be sure to be careful and likely submit even trivial changes to a new branch until I confident in the process. |
@matusi143 : Haha, we are not working in a strict law&order style, so don't be overly hesitant. ;-) |
@matusi143 https://github.com/matusi143 : Yes, don't be too conservative. 2014-07-08 13:45 GMT+02:00 Karl Rupp notifications@github.com:
|
@PhilippeTillet : We also have email notifications via the dashboard. I'll add you to that some time in the future, for now it's still a bit fragile so I don't want to throw too many false positives at you ;-) |
I just downloaded and attempted to the the latest version running using CMake. However, the make-file references a few things which I believe would need to be in my %PATH but I didn't want to do that as I change versions frequently. I tried to hard code them:
set(Boost_USE_STATIC_LIBS OFF)
set(Boost_USE_MULTITHREADED ON)
set(Boost_USE_STATIC_RUNTIME OFF)
find_package(Boost) _commented out in favor of the line below_
include_directories("C:/boost_1_54_0")
find OpenCL
find_package(OpenCL REQUIRED) **commented out in favor of the lines below **
include_directories(${OPENCL_INCLUDE_DIR})
link_directories(${OPENCL_LIBRARIES})
link_directories("C:/Users/matth_000/AMD APP SDK/2.9/lib/x86_64")
After these changes cmake appeared to run fine, although I was unsuccessful in getting the program to build in qt5. Perhaps I am missing some steps in the instructions.
If you could please provide more detailed steps for the cmake build process and provide either directions on how to use the find_package function or leave it as a build parameter it would be helpful.
The text was updated successfully, but these errors were encountered: