Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/weather error #199

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Chore/weather error #199

merged 2 commits into from
Feb 15, 2024

Conversation

samhwang
Copy link
Collaborator

Description

  • Separate the error object from weather error log so it can be viewed in Axiom
  • Add a function to construct the URL with multiple words before sending into the weather API, in case of a 404

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@samhwang samhwang merged commit 195ec33 into master Feb 15, 2024
3 of 4 checks passed
@samhwang samhwang deleted the chore/weather-error branch February 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samhwang