Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animations pt1 #84

Merged
merged 88 commits into from
May 29, 2018
Merged

Animations pt1 #84

merged 88 commits into from
May 29, 2018

Conversation

amymc
Copy link
Contributor

@amymc amymc commented Mar 28, 2018

Here goes nothing 🙈

#11

Still missing a couple of things:

  1. Hover animations
  2. Transitions on web

Handling animations of the same properties across multiple scopes (#11 (comment)) is not covered here either.

amymc and others added 30 commits February 27, 2018 00:20
@amymc
wip: extract animation props from value
6f84eeb
@amymc
wip: put animation props on node
edecaee
wip: expose animated props on willChange
96b7426
wip: add default duration if none stated
be97168
wip: convert strings to ints
272340d
wip: expose animated props on transition
6467997
wip: dont tag as animation if its a text node
fc21e97
wip: add defaults for delay and spring props
992c7da
wip: add getAnimatedValue fn on native
23d4259
wip: add animated values to style prop on native
177424e
wip: add animated as a dependency
e1971ff
fix: uses animated check
edb6ca2
wip: add componentWillReceiveProps for animated components
1408565
wip: add animated value
be34dff
fix: string interpolation
b32f067 
wip: use Animated.Text instead of Text element
wip: handle mix of animated and dynamic styles
fc06a21
fix: handle animated styles only
81c89cd
wip: handle multiple animations on diff scopes
3059b1c
@amymc
wip: handle timing animations on native
8d108ce
wip: allow for mix of timing and spring on same scope
6636258
fix: exisiting scope check
5ceaddb
wip: render animated spring on dom
33aa396
wip: add animated import on dom for springs
40334cc
wip: add getAnimatedValue fn for dom springs
a2574e8
chore: move get-animated-value to react directory
83f0717
fix: dont render Animation.iming on dom
d9ea6e6
wip: dont add spring animations to css transitions
e18b590
fix: keep willChange for dom springs
e8d4746
chore: remove old animated dependency
12d8874
wip: add animated values to style prop on dom for spring
f58b042
amymc and others added 26 commits May 18, 2018 22:18
feat: scope css vars to component
3a8e7d8
fix: use css instead of styled component
3fef18c
fix: use expanded transform name for var
996ccc3
fix: wrap transform vars in prop name
09068c7
wip: remove styled component
ae35e0a
fix: remove unnecessary backticks
5dda321
wip: put dynamic variable in style
d1bd0ec
fix: undefined units
8ed4086
fix: use vars for non-animated dynamic styles
13a0a03
chore: tidy up
7e7c384
chore: remove unused filter
07174bb
chore: remove unused exports
d37c316
chore: update snapshots
dcfab04
Merge remote-tracking branch 'origin' into animations-pt1
c89bf4d
fix: replace props for css vars on simple props
9414ae2
feat: add units to css vars and add css vars for simple props to style
093cf22
fix: update snapshots
4765d78
fix: css vars in transform
f16ad48
fix: units in getAnimatedValue
e065510
fix: remove duplicate vars in multi-scope props
3d7bb48
fix: remove random hash from classnames and ids
5071ee2
fix: id not to overlap in css styles and use emotion only
e814033
fix: hover
2d31d79
fix: enable animated in springs in dom
59811e0
Merge branch 'master' into animations-pt1
8f824c1 
* master:
  chore: release v13.1.1
  FlatList on native (#97)
chore: update tests
fd997f9
@dariocravero dariocravero merged commit cb335f2 into master May 29, 2018
@dariocravero dariocravero deleted the animations-pt1 branch May 29, 2018 23:35
dariocravero pushed a commit that referenced this pull request May 29, 2018
Merge branch 'master' of github.com:viewstools/morph
6071faf 
* 'master' of github.com:viewstools/morph:
  Animations pt1 (#84)
@dariocravero
Copy link

this absolutely epic 🎉!!!! well done @amymc, you rock!!! 🤘thank you so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariocravero dariocravero dariocravero left review comments

@tombrewsviews tombrewsviews Awaiting requested review from tombrewsviews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amymc @dariocravero