Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate forward_TV_mex.cpp in build system #33

Closed
GoogleCodeExporter opened this issue Apr 7, 2015 · 4 comments
Closed

Integrate forward_TV_mex.cpp in build system #33

GoogleCodeExporter opened this issue Apr 7, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Darryl has added a MEX function

FiltersToolbox/forward_TV_mex.cpp

Ramon to integrate in the CMake build system.

Original issue reported on code.google.com by rcas...@gmail.com on 23 Nov 2014 at 12:16

@GoogleCodeExporter
Copy link
Author

No urgency here - there is a Matlab version that does the same thing, just a 
little bit slower. If the images are quite small, the Matlab version might even 
be faster.

Original comment by Darryl.M...@gmail.com on 24 Nov 2014 at 11:15

@GoogleCodeExporter
Copy link
Author

No worries, Darryl, it has Priority-Low. It's more of a note to myself so I 
don't forget. But I'd like to see whether the function would work with the 
current build system. It doesn't link to external libraries, so it may be quite 
straightforward ;)

Original comment by rcas...@gmail.com on 25 Nov 2014 at 12:46

@GoogleCodeExporter
Copy link
Author

Darryl, I have added it in revision 1673: 
[https://code.google.com/p/gerardus/source/browse/trunk/matlab/FiltersToolbox/CM
akeLists.txt?r=1673#57 CMakeLists.txt]

If you can, please check that it works for you by building Gerardus. Or you can 
build only your auxiliary file doing

$ make forward_TV_mex

The name of the function should change, though. For an auxiliary function, 
forward_TV_aux.cpp would be less confusing than forward_TV_mex.cpp, I think ;)

Original comment by rcas...@gmail.com on 10 Feb 2015 at 11:39

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

PS. The build gives a warning, in case that's of any interest:

[100%] Building CXX object 
matlab/FiltersToolbox/CMakeFiles/forward_TV_mex.dir/forward_TV_mex.cpp.o
/home/rcasero/Software/gerardus/matlab/FiltersToolbox/forward_TV_mex.cpp: In 
function ‘void mexFunction(int, mxArray**, int, const mxArray**)’:
/home/rcasero/Software/gerardus/matlab/FiltersToolbox/forward_TV_mex.cpp:123:35:
 warning: comparison between signed and unsigned integer expressions 
[-Wsign-compare]
Linking CXX shared library forward_TV_mex.mexa64
[100%] Built target forward_TV_mex

Original comment by rcas...@gmail.com on 10 Feb 2015 at 11:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants