Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Missing carrierwave error #16

Merged
merged 3 commits into from
Jan 26, 2015

Conversation

bramswenson
Copy link
Contributor

Not all projects use Carrierwave. This change ensure those that don't can still use sprig-reap. Fixes #15 . There were also a couple of tests failing due to quoting issues, those are fixed in the second commit.

@h0tl33t
Copy link
Contributor

h0tl33t commented Jan 26, 2015

@bramswenson - Carrierwave fix looks good, but adding quotes to the yaml fixtures looks to have broken tests rather than fixed. The tests were passing before on Travis CI, so I'm curious as to what you were seeing in terms of test failures without those quotes.

@bramswenson
Copy link
Contributor Author

I bet it is a ruby version thing. I'm using one of the latest no doubt.
I'll check later and report back. I'm sure you know, but you can add a ruby
version matrix to .travis to test more rubies.
B!

On Mon, Jan 26, 2015 at 9:26 AM, Ryan Stenberg notifications@github.com
wrote:

@bramswenson https://github.com/bramswenson - Carrierwave fix looks
good, but adding quotes to the yaml fixtures looks to have broken tests
rather than fixed. The tests were passing before on Travis CI, so I'm
curious as to what you were seeing in terms of test failures without those
quotes.


Reply to this email directly or view it on GitHub
#16 (comment).

@bramswenson
Copy link
Contributor Author

Yep, I was using 2.1.2. Using 1.9.3 my changes fail as on travis. I'll revert that commit to get travis passing again. Thanks.

@h0tl33t
Copy link
Contributor

h0tl33t commented Jan 26, 2015

I'll look into newer versions of Ruby -- thanks for the heads up and the PR!

@bramswenson
Copy link
Contributor Author

No problem, added #17 to track that issue as well. Enjoy.

h0tl33t pushed a commit that referenced this pull request Jan 26, 2015
@h0tl33t h0tl33t merged commit 8d7c59d into vigetlabs:master Jan 26, 2015
@bramswenson bramswenson deleted the missing_carrierwave_error branch January 26, 2015 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sprig-reap won't write to file ?
2 participants