Bump dependencies #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoux
reviewed
Jun 12, 2023
| self.writer.add_document(doc); | ||
| match self.writer.add_document(doc) { | ||
| Ok(_) => log::debug!("Successfully saved file"), | ||
| Err(e) => log::warn!("Failed to save file due to {}", e), |
There was a problem hiding this comment.
I'd rather have that as an error ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I got interested in your project and I decided to have a look at the code, as I'm learning rust.
This felt like a good way to get acquainted with the language in a real-world scenario.
I bumped a few of the libraries, but I didn't bump tantivy too much because it seems to change the function APIs quite drastically, and since I don't have enough context of the code here, I didn't want to introduce too much change yet.
I'd be happy to take another stab at bumping tantivy in the future.
Best regards,