deduplicate channels #332
Merged
deduplicate channels #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a field is reused for multiple redundant encodings, make sure it's only listed once in the tooltips and descriptions.
|
This implementation uses ES6 object key iteration order, such that earlier channels are preserved and later channels are omitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to reuse channels for redundant encodings, such as a bar chart where every bar is a different color because color and bar position are reading from the same data field. When that is expressed via text as with a tooltip or a table or the
aria-labelattribute, however, the redundant visual mapping becomes redundant text. Cleaning this up requires deduplicating the channels by making sure the associated fields are never repeated.