Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Telefunc boilerplate? #378

Closed
brillout opened this issue Sep 16, 2024 · 8 comments
Closed

Broken Telefunc boilerplate? #378

brillout opened this issue Sep 16, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@brillout
Copy link
Member

Describe the bug

The generated boilerplate for Telefunc seems broken.

To Reproduce

pnpm create bati --telefunc --hono

Expected behavior

A boilerplate that kind of make sense.

@brillout brillout added the bug Something isn't working label Sep 16, 2024
@brillout
Copy link
Member Author

brillout commented Sep 16, 2024

Ah, I omitted React/Vue/Solid that's maybe why. Let me try with a UI framework.

@brillout
Copy link
Member Author

With React, the generated boilerplate is quite good. Although it'd be nice if pages/todo/TodoList.telefunc.ts > onNewTodo() mutates the database instead of just printing a message.

@magne4000
Copy link
Member

magne4000 commented Sep 16, 2024

Related to #263

With React, the generated boilerplate is quite good. Although it'd be nice if pages/todo/TodoList.telefunc.ts > onNewTodo() mutates the database instead of just printing a message.

It does if you select a DB like sqlite or drizzle

@brillout
Copy link
Member Author

I'd like to use pnpm create bati --{react,vue,solid} --telefunc --hono for creating repos that will be linked next to the Vike Talk. It'b nice to have something minimal that reproduces Next.js.

@magne4000
Copy link
Member

I'd like to use pnpm create bati --{react,vue,solid} --telefunc --hono for creating repos that will be linked next to the Vike Talk. It'b nice to have something minimal that reproduces Next.js.

What would you need that is not available?

@brillout
Copy link
Member Author

What would you need that is not available?

I think it's perfect! Just did a bit of polishing, see my PRs.

@brillout
Copy link
Member Author

The only thing is that I'm thinking maybe we really should be removing that plain Vike boilerplate, it's quite a frankenstein :) But I don't know whether it's a lot of effort to remove 👀

@magne4000
Copy link
Member

I will remove it, it's half-baked and doesn't serve any real purpose. I just need to find a way to adapt the UI (I'll probably pre-select react)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants