Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot do query-param-only transition #45

Closed
lougreenwood opened this issue Oct 17, 2021 · 2 comments
Closed

Cannot do query-param-only transition #45

lougreenwood opened this issue Oct 17, 2021 · 2 comments

Comments

@lougreenwood
Copy link

lougreenwood commented Oct 17, 2021

The router service allows query-param only transitions:

    this.router.transitionTo({
      queryParams: { commentsAfter: latestComment }
    });

However, the logic for EngineRouterService does not handle this: https://github.com/villander/ember-engines-router-service/blob/master/addon/services/engine-router-service.js#L64

The problem seems to be that if routeName does not resemble a URL, it still tries to use routeName as the arg.

@villander villander added bug Something isn't working and removed bug Something isn't working labels Jan 30, 2022
@villander
Copy link
Owner

@lougreenwood could you please provide a minimal reproduction?

@villander
Copy link
Owner

I'm closing this issue for inactivity and will reopen once someone reply with a minimal reproduction 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants