Update README.md #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing parens and declare missing variable in example.
|
Thanks a lot for this! |
vilya
added a commit
that referenced
this pull request
Oct 29, 2020
PR #3 pointed out some typos in the "how to load a triangle mesh" sample code. One of them was an undefined variable, `propIdx`, when checking whether we need to triangulate the face data. I noticed after merging the PR that it was attempting to work around a typo I'd made in the variable name: it should actually have been `indexes[0]` (or `*indexes`) instead. I'm just fixing that up here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some small issues in the README. This pull request fixes missing parens and declares a missing variable in the example.