-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👍 Use Web Streams API instead of Deno.Reader/Deno.Writer to follow recent deno favor #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdalisue
changed the title
Use Web Streams API instead of Deno.Reader/Deno.Writer to follow recent deno favor
💥 Use Web Streams API instead of Deno.Reader/Deno.Writer to follow recent deno favor
May 8, 2023
lambdalisue
force-pushed
the
stream
branch
3 times, most recently
from
May 11, 2023 14:35
2a3ed1e
to
535a300
Compare
To avoid reling on the `msgpack_rpc` module
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v5 #249 +/- ##
=====================================
Coverage ? 92.68%
=====================================
Files ? 3
Lines ? 82
Branches ? 6
=====================================
Hits ? 76
Misses ? 6
Partials ? 0 ☔ View full report in Codecov by Sentry. |
lambdalisue
changed the title
💥 Use Web Streams API instead of Deno.Reader/Deno.Writer to follow recent deno favor
👍 Use Web Streams API instead of Deno.Reader/Deno.Writer to follow recent deno favor
May 14, 2023
Milly
reviewed
May 15, 2023
Shougo
approved these changes
May 16, 2023
Co-authored-by: Milly <milly.ca@gmail.com>
Milly
approved these changes
May 16, 2023
We'll release v5 in this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ReadableStream<Uint8Array>
andWritableStream<Uint8Array>
internally. It does not change APIs of denops itself so it should be a non breaking change.This change will reduce one-shot RPC performance, but appears to improve performance when accessed in batches.
Benchmark with Deno v1.33.3
Vim
Before
After
Neovim
Before
After