Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☕ Fix update workflow #288

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

hasundue
Copy link
Contributor

@hasundue hasundue commented Nov 4, 2023

This PR fixes the following problem with release workflow:

  • The workflow fails when a PR already exists
  • CI does not run when updates are force-pushed to an existing PR

Test run and its resulting PR on my fork:

@hasundue hasundue changed the title ci fix update ☕ fix update workflow Nov 4, 2023
@hasundue hasundue force-pushed the ci-fix-update branch 3 times, most recently from 710d8a2 to 1117115 Compare November 7, 2023 13:18
@hasundue hasundue changed the title ☕ fix update workflow ☕ Fix update workflow Nov 7, 2023
@hasundue hasundue force-pushed the ci-fix-update branch 2 times, most recently from ce8583d to 96d8cbf Compare November 7, 2023 14:00
@hasundue hasundue marked this pull request as ready for review November 7, 2023 14:05
@hasundue
Copy link
Contributor Author

hasundue commented Nov 8, 2023

Note that the PR title is determined conditionally: https://github.com/hasundue/molt/blob/ca89c0a6253df13a97d9fa1bb7ad8965c3ea8931/cli.ts#L286

It becomes "update dependencies" when there are multiple updates.

@lambdalisue lambdalisue merged commit 8b53173 into vim-denops:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants