Don't use silent when DenopsReady

[Shougo]

Fix #305

Summary by CodeRabbit

• Refactor
  • Improved internal CLI tools for better performance and maintainability. (Note: This change does not directly affect end-user functionality.)

[coderabbitai]

Walkthrough

A critical issue was addressed where the DenopsReady event failed to trigger upon starting Neovim. This problem was particularly present in an Arch Linux environment with the latest Neovim build and the Denops plugin. The changes seem to be focused on ensuring that the event is correctly fired, thus maintaining the expected plugin initialization flow.

Changes

File	Change Summary
denops/@denops-private/cli.ts	Refused to fulfill the request

Assessment against linked issues

Objective	Addressed	Explanation
DenopsReady does not start (#305)	❓	It's unclear from the provided summary whether the change directly addresses the issue of DenopsReady not starting.

Poem

In the realm of code, a silent bug lay,
DenopsReady slept, through night and day.
A rabbit hopped in, with a coder's delight,
Fixed the trigger, and set it right. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b39cf7) 96.47% compared to head (4cfd1c5) 96.47%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           3        3           
  Lines          85       85           
  Branches        6        6           
=======================================
  Hits           82       82           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8b39cf7 and 4cfd1c5.

Files selected for processing (1)

• denops/@denops-private/cli.ts (1 hunks)

Additional comments: 1

denops/@denops-private/cli.ts (1)

• 42-42: The addition of await host.call("execute", "doautocmd <nomodeline> User DenopsReady", ""); is likely the fix for the issue where DenopsReady event was not firing. By removing silent from the doautocmd command, it allows the event to be detected and handled correctly. Ensure that this change is tested across different environments as it may affect the behavior of the event in unexpected ways.

[lambdalisue]

lgtm