🐛 Fix "once" callback leak

[Milly]

There was a leak where unregistering was not call if the "once" callback aborted.

• Remove directly without calling the unregister method due to overhead.
• Delete unnecessary silent.

Summary by CodeRabbit

• Refactor
  • Improved the logic for unregistering callback functions and handling the once option in the callback system.

[coderabbitai]

Walkthrough

The recent modifications focus on refining the callback management in the Vim script. Changes primarily address the deregistration process and the handling of callbacks marked with the once option, enhancing the efficiency and clarity of the code by simplifying the steps involved in unregistering callbacks.

Changes

File Path	Change Summary
autoload/.../callback.vim	Updated the logic for unregistering callback functions and improved handling of the once option by directly unsetting the registry entries.

Poem

🌟🐰✨
In the land of code and vim,
A rabbit hopped, with vim and vigor trim.
Tweaked the callbacks, one by one,
Now they unregister, oh what fun!
Hop, skip, a code fix spree,
A bunny’s touch, as swift as can be!
🌟🐰✨

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 2d11652 and c151acc.

Files selected for processing (1)

• autoload/denops/callback.vim (1 hunks)

Additional comments not posted (2)

autoload/denops/callback.vim (2)

20-20: Directly unsetting the registry entry simplifies the callback management process.

---

29-29: Directly unsetting the registry entry for 'once' callbacks is an efficient way to ensure they are not called multiple times.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (2d11652) to head (c151acc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files           9        9           
  Lines         648      648           
  Branches       61       61           
=======================================
  Hits          582      582           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.