-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👍 Improve error message of call
#374
Conversation
Warning Review failedThe pull request is closed. WalkthroughThis update improves the error handling within the Changes
Sequence Diagram(s)sequenceDiagram
participant Plugin
participant Dispatcher
participant Error
Plugin->>Dispatcher: dispatcher[fn](...args)
Dispatcher-->>Plugin: Error response
Plugin->>Error: Capture error
Plugin->>Plugin: Format error message
Plugin-->>Error: Throw new error with detailed message
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 90.23% 90.17% -0.07%
==========================================
Files 9 9
Lines 676 682 +6
Branches 64 66 +2
==========================================
+ Hits 610 615 +5
- Misses 66 67 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- denops/@denops-private/service.ts (1 hunks)
Additional context used
GitHub Check: codecov/patch
denops/@denops-private/service.ts
[warning] 183-184: denops/@denops-private/service.ts#L183-L184
Added lines #L183 - L184 were not covered by tests
|
a1791d9
to
40c0a34
Compare
Close #373
Summary by CodeRabbit