Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vim-jp bot app when running depup #1598

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

k-takata
Copy link
Member

CI jobs were not automatically executed because we used GITHUB_TOKEN.
To work around the restriction of GITHUB_TOKEN, use action/create-github-app-token to generate a token.

See:

@k-takata
Copy link
Member Author

とりあえずマージしてしまって、次回 reviewdog が更新された際に意図通りジョブが自動で走るかどうか確認したいと思います。

@k-takata k-takata merged commit 1de1007 into master Jun 26, 2024
3 checks passed
@k-takata k-takata deleted the use-vim-jp-bot-app-when-running-depup branch June 26, 2024 11:41
@k-takata
Copy link
Member Author

k-takata commented Jun 27, 2024

設定内容の補足です。
vim-jp bot app というものを登録し、(今のところ) vim-jp/vimdoc-ja-working と vim-jp/vital.vim にインストールしてあります。vim-jp bot app には、コミットと PR の作成に必要な権限(※)を与えてあります。
さらに、vim-jp organization の variables に VIM_JP_BOT_APP_ID を登録し、secrets に VIM_JP_BOT_PRIVATE_KEY を登録しました。これを actions/create-github-app-token に渡すことで、GITHUB_TOKEN の代わりに使えるトークンが発行されるようになっています。

※Repository permissions として、以下の3項目を許可

  • Contents: Read and write
  • Metadata (mandatory): Read-only
  • Pull requests: Read and write

k-takata added a commit to vim-jp/vital.vim that referenced this pull request Jul 13, 2024
k-takata added a commit to vim-jp/vital.vim that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants