Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update tests for Async.Promise .wait #810

Merged
merged 6 commits into from
Aug 6, 2024
Merged

fix: Update tests for Async.Promise .wait #810

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4517cb6
fix: Update test for Promise.wait timing check
tsuyoshicho Mar 16, 2024
396d666
fix: Expand range for wait test on mac
tsuyoshicho Mar 16, 2024
2e3e418
fix: test miss (done time)
tsuyoshicho Mar 16, 2024
e780276
chore: Update comment position
tsuyoshicho Mar 16, 2024
3398352
fix: Update comment by review suggestion
tsuyoshicho Mar 16, 2024
a74118e
fix: Update comment by review suggestion
tsuyoshicho Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 71 additions & 13 deletions test/Async/Promise.vimspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,33 +788,91 @@ Describe Async.Promise
Assert Compare(done, '<=', 2000)
End

It waits at least the interval milliseconds (interval < epoch)
let p = Wait(1000).then({ -> 'resolved' })
It waits within the interval range ((interval * n) <= epoch <= (interval * (n + 1))) until resolve
let p = Wait(500).then({ -> 'resolved' })
let s = reltime()
Assert Equals(p._state, PENDING)
" Timer accuracy fixing need
Assert Equals(P.wait(p, { 'interval': 340 }), ['resolved', v:null])
Assert Equals(P.wait(p, { 'interval': 200 }), ['resolved', v:null])
let done = reltimefloat(reltime(s)) * 1000
Assert Compare(done, '>=', 1000)
" interval period | 1 | 2 | 3 | 4 | 5 | 6
" elapsed time |* 0 |* 200 |* 400 |* 600 |* 800 |* 1000
" detect time range | +------+
" complete timing |---------------o 500
" lower limit : 600, upper limit : 800
if has('mac')
" TODO: I know this is a terrible IDEA, but this assert makes osx test fails.
" Let's disable until we figure out why and how.
" Because the time required for a result is not stable on mac, we will expand the wait time range to test the time test
" It can either underflow or overflow.
Assert Compare(done, '>=', 400)
Assert Compare(done, '<=', 1000)
else
Assert Compare(done, '<=', 1360)
Assert Compare(done, '>=', 600)
Assert Compare(done, '<=', 800)
endif

let p = Wait(1000).then({ -> P.reject('rejected') })
let p = Wait(700).then({ -> 'resolved' })
let s = reltime()
Assert Equals(p._state, PENDING)
" Timer accuracy fixing need
Assert Equals(P.wait(p, { 'interval': 340 }), [v:null, 'rejected'])
Assert Equals(P.wait(p, { 'interval': 200 }), ['resolved', v:null])
let done = reltimefloat(reltime(s)) * 1000
Assert Compare(done, '>=', 1000)
" interval period | 1 | 2 | 3 | 4 | 5 | 6
" elapsed time |* 0 |* 200 |* 400 |* 600 |* 800 |* 1000
" detect time range | +------+
" complete timing |----------------------o 700
" lower limit : 800, upper limit : 1000
if has('mac')
" Because the time required for a result is not stable on mac, we will expand the wait time range to test the time test
" It can either underflow or overflow.
Assert Compare(done, '>=', 600)
Assert Compare(done, '<=', 1200)
else
Assert Compare(done, '>=', 800)
Assert Compare(done, '<=', 1000)
endif
End

It waits within the interval range ((interval * n) <= epoch <= (interval * (n + 1))), until reject
let p = Wait(500).then({ -> P.reject('rejected') })
let s = reltime()
Assert Equals(p._state, PENDING)
" Timer accuracy fixing need
Assert Equals(P.wait(p, { 'interval': 200 }), [v:null, 'rejected'])
let done = reltimefloat(reltime(s)) * 1000
" interval period | 1 | 2 | 3 | 4 | 5 | 6
" elapsed time |* 0 |* 200 |* 400 |* 600 |* 800 |* 1000
" detect time range | +------+
" complete timing |---------------o 500
" lower limit : 600, upper limit : 800
if has('mac')
" Because the time required for a result is not stable on mac, we will expand the wait time range to test the time test
" It can either underflow or overflow.
Assert Compare(done, '>=', 400)
Assert Compare(done, '<=', 1000)
else
Assert Compare(done, '>=', 600)
Assert Compare(done, '<=', 800)
endif

let p = Wait(700).then({ -> P.reject('rejected') })
let s = reltime()
Assert Equals(p._state, PENDING)
" Timer accuracy fixing need
Assert Equals(P.wait(p, { 'interval': 200 }), [v:null, 'rejected'])
let done = reltimefloat(reltime(s)) * 1000
" interval period | 1 | 2 | 3 | 4 | 5 | 6
" elapsed time |* 0 |* 200 |* 400 |* 600 |* 800 |* 1000
" detect time range | +------+
" complete timing |----------------------o 700
" lower limit : 800, upper limit : 1000
if has('mac')
" TODO: I know this is a terrible IDEA, but this assert makes osx test fails.
" Let's disable until we figure out why and how.
" Because the time required for a result is not stable on mac, we will expand the wait time range to test the time test
" It can either underflow or overflow.
Assert Compare(done, '>=', 600)
Assert Compare(done, '<=', 1200)
else
Assert Compare(done, '<=', 1360)
Assert Compare(done, '>=', 800)
Assert Compare(done, '<=', 1000)
endif
End
End
Expand Down
Loading