Update Logtalk runtime files for the latest language spec #13697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkearns
requested changes
Dec 16, 2023
runtime/syntax/logtalk.vim
Outdated
| command -nargs=+ HiLink hi link <args> | ||
| else | ||
| command -nargs=+ HiLink hi def link <args> | ||
| endif |
There was a problem hiding this comment.
This HiLink compatibility command was removed from the distributed runtime files about eight years ago. So, the original file using hi def link is actually the correct approach.
There was a problem hiding this comment.
Thanks for the quick feedback. Fixed.
dkearns
requested changes
Dec 16, 2023
runtime/syntax/logtalk.vim
Outdated
|
|
||
| if version < 600 | ||
| syntax clear | ||
| elseif exists("b:current_syntax") | ||
| finish | ||
| endif | ||
|
|
There was a problem hiding this comment.
Likewise, the original file is the correct approach here.
pmoura
force-pushed
the
update_logtalk_support
branch
from
86234dc to
c2a56d5
Compare
|
thanks! |
clason
added a commit
to clason/neovim
that referenced
this pull request
Dec 16, 2023
runtime(logtalk): Update Logtalk runtime files for the latest language spec (vim/vim#13697) vim/vim@0f61943 Co-authored-by: Paulo Moura <pmoura@logtalk.org>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Dec 16, 2023
runtime(logtalk): Update Logtalk runtime files for the latest language spec (vim/vim#13697) vim/vim@0f61943 Co-authored-by: Paulo Moura <pmoura@logtalk.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request also fixes some syntax highlight bugs.