Skip to content

Highlight more awk comments #15944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Highlight more awk comments #15944

wants to merge 1 commit into from

Conversation

jmdevin
Copy link
Contributor

@jmdevin jmdevin commented Oct 26, 2024

Some awk comments are not highlighted. The following is valid awk:

{ # Comment
    for (i = 0; # BAD
        i < 1; # BAD
        i++) # Comment
    { # Comment
        print # Comment
    } # Comment
} # Comment

In vim, the two comments # BAD are not currently highlighted. This fixes that issue.

@jmdevin
Copy link
Contributor Author

jmdevin commented Oct 26, 2024

@dkearns for review.

@chrisbra
Copy link
Member

Thanks. Can you please create a syntax test for awk for this issue?

@jmdevin
Copy link
Contributor Author

jmdevin commented Oct 28, 2024

I think I added the test correctly. I'd like to expand it to be more comprehensive, but not a lot of time right now, unless there's anything specific you'd prefer added to it.

Copy link
Contributor

@dkearns dkearns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chrisbra chrisbra closed this in 1e2007e Oct 28, 2024
@chrisbra
Copy link
Member

thanks!

clason added a commit to clason/neovim that referenced this pull request Oct 28, 2024
…x script

closes: vim/vim#15944

vim/vim@1e2007e

Co-authored-by: John M Devin <john.m.devin@gmail.com>
clason added a commit to neovim/neovim that referenced this pull request Oct 29, 2024
…x script

closes: vim/vim#15944

vim/vim@1e2007e

Co-authored-by: John M Devin <john.m.devin@gmail.com>
techntools pushed a commit to techntools/vim that referenced this pull request Nov 3, 2024
closes: vim#15944

Signed-off-by: John M Devin <john.m.devin@gmail.com>
Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants