runtime(gleam): add syntax and compiler and update ftplugin #17172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillmorozov
commented
Apr 20, 2025
lpil
reviewed
Apr 20, 2025
kirillmorozov
force-pushed
the
master
branch
2 times, most recently
from
3f352b7 to
becf330
Compare
lpil
reviewed
Apr 20, 2025
dkearns
requested changes
Apr 22, 2025
runtime/compiler/gleam.vim
Outdated
| " Vim compiler file | ||
| " Language: Gleam | ||
| " Maintainer: Kirill Morozov <kirill@robotix.pro> | ||
| " Based On: https://github.com/gleam-lang/gleam.vim |
There was a problem hiding this comment.
Is this going to be the upstream repo? If so, the comment title is usually URL: .
There was a problem hiding this comment.
Nope, it's going to be deprecated.
runtime/compiler/gleam.vim
Outdated
| " Language: Gleam | ||
| " Maintainer: Kirill Morozov <kirill@robotix.pro> | ||
| " Based On: https://github.com/gleam-lang/gleam.vim | ||
| " Last Change: 2025-04-20 |
There was a problem hiding this comment.
Suggested change
| " Last Change: 2025-04-20 | |
| " Last Change: 2025 Apr 20 |
I know there's multiple formats but this is the gold standard.
runtime/compiler/gleam.vim
Outdated
| CompilerSet errorformat=%Eerror:\ %m | ||
| CompilerSet errorformat+=%Wwarning:\ %m | ||
| CompilerSet errorformat+=%C\ %#┌─%#\ %f:%l:%c\ %#-%# | ||
|
|
There was a problem hiding this comment.
The efm lines need to be separated with ,
runtime/ftplugin/gleam.vim
Outdated
|
|
||
| if !exists('current_compiler') | ||
| compiler gleam | ||
| let b:undo_ftplugin .= "| compiler make" |
There was a problem hiding this comment.
Suggested change
| let b:undo_ftplugin .= "| compiler make" | |
| let b:undo_ftplugin ..= "| compiler make" |
We should really be using .. everywhere.
Signed-off-by: Kirill Morozov <kirill@robotix.pro>
Signed-off-by: Kirill Morozov <kirill@robotix.pro>
Signed-off-by: Kirill Morozov <kirill@robotix.pro>
Signed-off-by: Kirill Morozov <kirill@robotix.pro>
|
alright, thanks all |
clason
added a commit
to clason/neovim
that referenced
this pull request
Apr 25, 2025
…w compiler and syntax script closes: vim/vim#17172 vim/vim@32f4973 Co-authored-by: Kirill Morozov <mail2kirill@gmail.com>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Apr 25, 2025
…w compiler and syntax script closes: vim/vim#17172 vim/vim@32f4973 Co-authored-by: Kirill Morozov <mail2kirill@gmail.com>
brynne8
pushed a commit
to brynne8/neovim
that referenced
this pull request
Apr 25, 2025
…w compiler and syntax script closes: vim/vim#17172 vim/vim@32f4973 Co-authored-by: Kirill Morozov <mail2kirill@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @lpil's approval I decided to incorporate syntax, ftplugin and compiler from the official Gleam Vim plugin into the Vim repo.
I've made the following changes to the files in the process:
_separator.commentsbecause they do not exist in Gleam and removetextwidthoption.Related-to: gleam-lang/gleam.vim#15
Signed-off-by: Kirill Morozov kirill@robotix.pro