Tabulators are not highlighted completely with 'linebreak' enabled

[wrtlprnft]

Steps to reproduce

Run this shell command:

vim -Nu NONE -S <(cat <<'EOF'
	call matchadd('ErrorMsg', '\t', 5)
	set linebreak
	normal ix
	normal >>
EOF
)

Expected behaviour

I expect all columns that belong to the tab character to be highlighted, like this:

This is the behavior of vim up to v8.2.3697.

Instead, only the first column gets highlighted:

This is the behavor with v8.2.3698 (the fix for issue #9242) and v8.2.4051 (current master).

Version of Vim

8.2.4051

Environment

OS: Gentoo
$TERM: screen.xterm-256color (also happens with GTK GUI)

Logs and stack traces

No response

[chrisbra]

Hm, I think we just need this one:

diff --git a/src/drawline.c b/src/drawline.c
index 8a042ed3e..1c7859acd 100644
--- a/src/drawline.c
+++ b/src/drawline.c
@@ -2043,7 +2043,7 @@ win_line(
                        if (n_extra < 0)
                            n_extra = 0;
                    }
-                   if (on_last_col)
+                   if (on_last_col && c != TAB)
                        // Do not continue search/match highlighting over the
                        // line break.
                        search_attr = 0;

@lacygoill I didn't fully understand your #9242 but I think this change shouldn't affect it.

[lacygoill]

@lacygoill I didn't fully understand your #9242 but I think this change shouldn't affect it.

I can confirm that the patch doesn't introduce a regression, and that it fixes the current issue:

diff --git a/src/drawline.c b/src/drawline.c
index 8a042ed3e..1c7859acd 100644
--- a/src/drawline.c
+++ b/src/drawline.c
@@ -2043,7 +2043,7 @@ win_line(
 			if (n_extra < 0)
 			    n_extra = 0;
 		    }
-		    if (on_last_col)
+		    if (on_last_col && c != TAB)
 			// Do not continue search/match highlighting over the
 			// line break.
 			search_attr = 0;

Thank you very much for the quick fix.

[wrtlprnft]

I can confirm that this patch also fixes the actual issue/regression I have with my full vimrc. Thank you very much for the quick replies!

[chrisbra]

okay I have created #9507 to address this