Throw error if setcellwidths() invalidates 'listchars' or 'fillchars' #9024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeertzjq
force-pushed
the
setcellwidths-conflict
branch
from
855b589
to
d3108e9
Compare
|
I think some documentation should be added about this, but I cannot decide how. |
zeertzjq
force-pushed
the
setcellwidths-conflict
branch
3 times, most recently
from
85292d1
to
eb4b3d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #9024 +/- ##
===========================================
- Coverage 90.06% 2.45% -87.61%
===========================================
Files 151 149 -2
Lines 168477 166109 -2368
===========================================
- Hits 151736 4085 -147651
- Misses 16741 162024 +145283
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Maybe move E834 and E835 tags to somewhere else? |
zeertzjq
changed the title
zeertzjq
force-pushed
the
setcellwidths-conflict
branch
from
eb4b3d7
to
c92422b
Compare
delphinus
added a commit
to delphinus/neovim
that referenced
this pull request
Aug 6, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1
delphinus
added a commit
to delphinus/neovim
that referenced
this pull request
Aug 6, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1
delphinus
added a commit
to delphinus/neovim
that referenced
this pull request
Aug 6, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1
delphinus
added a commit
to delphinus/neovim
that referenced
this pull request
Aug 6, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1
delphinus
added a commit
to delphinus/neovim
that referenced
this pull request
Aug 7, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Aug 8, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1 Cherry-pick f_setcellwidths() change from patch 9.0.0036. Cherry-pick 'ambiwidth' docs update from runtime update 079ba76ae7a7.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Aug 8, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1 Cherry-pick f_setcellwidths() change from patch 9.0.0036. Cherry-pick 'ambiwidth' docs update from runtime update 079ba76ae7a7.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Aug 8, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1 Cherry-pick f_setcellwidths() change from patch 9.0.0036. Cherry-pick 'ambiwidth' docs update from runtime update 079ba76ae7a7.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Aug 8, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1 Cherry-pick f_setcellwidths() change from patch 9.0.0036. Cherry-pick 'ambiwidth' docs update from runtime update 079ba76ae7a7.
smjonas
pushed a commit
to smjonas/neovim
that referenced
this pull request
Dec 31, 2022
…s' invalid Problem: setcellwidths() may make 'listchars' or 'fillchars' invalid. Solution: Check the value and give an error. (closes vim/vim#9024) vim/vim@94358a1 Cherry-pick f_setcellwidths() change from patch 9.0.0036. Cherry-pick 'ambiwidth' docs update from runtime update 079ba76ae7a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.