firebase auth implemented. #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimark1
approved these changes
Oct 22, 2018
There was a problem hiding this comment.
This look great @smkamranqadri
Eventually we want to add Google as an auth mechanism also but that can come later.
There's just one test failing on this PR, are you able to fix it? Then we could merge.
I also need to setup a Firebase instance for the main public app
vimark1
added a commit
that referenced
this pull request
Oct 22, 2018
|
I have merged this PR manually and fixed the failing test |
1 similar comment
|
I have merged this PR manually and fixed the failing test |
|
It’s weird. I can’t close this PR for some reason. The work has been merged though |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added firebase and auth along side a navbar to show signup, signin, signout.