Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.json #340

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Update tsconfig.json #340

merged 1 commit into from
Nov 4, 2022

Conversation

g3r4n
Copy link
Contributor

@g3r4n g3r4n commented Nov 3, 2022

Pull request type

What is the current behavior?

lot of warning in webpack build + dev
exemple:

WARNING in ./node_modules/@vime/react/dist/esm/lib.jsx
Module Warning (from ./node_modules/react-scripts/node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from 'XXX/node_modules/@vime/react/src/lib.tsx' file: Error: ENOENT: no such file or directory, open 'XXX/node_modules/@vime/react/src/lib.tsx'

This is mainly due to the the fact that the src aren't shipped to npm. we either include the src or we don't ship any sourcemap

What is the new behavior?

Do not ship sourcemap

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Nov 3, 2022

@g3r4n is attempting to deploy a commit to the Vidstack Team on Vercel.

A member of the Team first needs to authorize it.

@mihar-22 mihar-22 merged commit 690d8df into vime-js:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants