fix: Dailymotion qualities selector. #375
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
The playback quality selector is not working.
The error is happening because the query is not decoded correctly in
parseQueryString
. Then in the file below we get aCannot read properties of undefined
besausequalities
doesn't exist.vime/packages/core/src/components/providers/dailymotion/dailymotion.tsx
Lines 338 to 343 in 0d0df2e
Input:
before
after
What is the new behavior?
Fix the playback quality selector.
Does this introduce a breaking change?
Other information
Before the list of qualities is not displayed:
After the change: