Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and cleanup for SRT package #7

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Minor fixes and cleanup for SRT package #7

merged 2 commits into from
Jul 12, 2022

Conversation

robertbenjamin
Copy link
Contributor

Few small improvements to the SRT package:

  • Fixes an issue where font color wasn't being stripped from caption text correctly
  • Updated the font color regex pattern to be more generic after checking the SRT spec online (i.e. <font color=“anystring”></font> is matched instead of just <font color=“#001f3f”></font>)
  • Adds a test ensuring font color is stripped correctly
  • Uses the caps.DefaultLang const instead of en-US
  • Adds a few tests ensuring invalid SRT files fail detection
  • Uppercases naming of the SRT fixture files so they'll be exported and available for when we add SRT -> (Other caption format) conversion tests

@robertbenjamin robertbenjamin marked this pull request as ready for review July 11, 2022 22:40
@robertbenjamin robertbenjamin merged commit 95b4e72 into master Jul 12, 2022
@robertbenjamin robertbenjamin self-assigned this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamNastasia AdamNastasia AdamNastasia approved these changes

@thiagopnts thiagopnts thiagopnts approved these changes

Assignees

@robertbenjamin robertbenjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbenjamin @thiagopnts @AdamNastasia