Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements in the Latest Update #102

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Enhancements in the Latest Update #102

wants to merge 9 commits into from

Conversation

shukriYusof
Copy link

  • A chore was performed to include an additional example for using the Laravel facade.
  • A new feature was introduced to provide video ID validation rules.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Tofandel
Tofandel reviewed Feb 7, 2024
View reviewed changes
src/Rules/VideoIdRule.php
use Illuminate\Contracts\Validation\Rule;
use Vimeo\Laravel\Facades\Vimeo;

class VideoIdRule implements Rule
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already separately in this PR https://github.com/vimeo/laravel/pull/92/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofandel Tofandel Tofandel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shukriYusof @CLAassistant @Tofandel