Add Vault EngineType #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinagada
approved these changes
Oct 2, 2019
sergiosalvatore
force-pushed
the
add-backend
branch
from
20e53dc
to
d777199
Compare
Apparently, Vault secrets engines have slightly different API responses
which need to be parsed differently. In particular, kv-v2 (version 2 of
the Key/Value secrets engine) has an extra layer of data wrapping so
responses look like this:
```json
{
"request_id": "78b921ae-79a8-d7e3-da16-336b634fff22",
"lease_id": "",
"renewable": false,
"lease_duration": 0,
"data": {
"data": {
"foo": "world"
},
"metadata": {
"created_time": "2019-10-01T19:36:25.285387Z",
"deletion_time": "",
"destroyed": false,
"version": 1
}
},
"wrap_info": null,
"warnings": null,
"auth": null
}
```
Data data data data data.
kv version1 secrets look like this:
```json
{
"request_id": "12a0c057-f475-4bbd-6305-e4c07e66805c",
"lease_id": "",
"renewable": false,
"lease_duration": 2764800,
"data": {
"foo": "world"
},
"wrap_info": null,
"warnings": null,
"auth": null
}
```
Since we don't know which version Vault will have mounted where we have
to specify an engine type per mapping. This is inconvenient, so I've
also added a `defaultEngineType` which will be used when one isn't
defined at the mapping level.
Also, all tests have been updated to run with all engine types to catch
any issues.
sergiosalvatore
force-pushed
the
add-backend
branch
from
d777199
to
bffcaea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, Vault secrets engines have slightly different API responses
which need to be parsed differently. In particular, kv-v2 (version 2 of
the Key/Value secrets engine) has an extra layer of data wrapping so
responses look like this:
{ "request_id": "78b921ae-79a8-d7e3-da16-336b634fff22", "lease_id": "", "renewable": false, "lease_duration": 0, "data": { "data": { "foo": "world" }, "metadata": { "created_time": "2019-10-01T19:36:25.285387Z", "deletion_time": "", "destroyed": false, "version": 1 } }, "wrap_info": null, "warnings": null, "auth": null }Data data data data data.
kv version1 secrets look like this:
{ "request_id": "12a0c057-f475-4bbd-6305-e4c07e66805c", "lease_id": "", "renewable": false, "lease_duration": 2764800, "data": { "foo": "world" }, "wrap_info": null, "warnings": null, "auth": null }Since we don't know which version Vault will have mounted where we have
to specify an engine type per mapping. This is inconvenient, so I've
also added a
defaultEngineTypewhich will be used when one isn'tdefined at the mapping level.
Also, all tests have been updated to run with all engine types to catch
any issues.