Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few cleanups (see individual commits) #2

Merged
merged 4 commits into from
May 7, 2019
Merged

A few cleanups (see individual commits) #2

merged 4 commits into from
May 7, 2019

Conversation

dfinkel
Copy link
Collaborator

@dfinkel dfinkel commented May 7, 2019

  • go mod tidy
  • separate out local packages from other imports
  • simplify the Dockerfile and Makefile

@dfinkel
docker and makefile cleanup
5ef8a9c 
Remove gomod_deps support as this is an open source project that will
never have any private dependencies that require credentials to fetch.

Add a `pentagon` user to the final dockerfile and drop privileges when
running.
@dfinkel
import tidying: separate local imports
2f9c400
@dfinkel
Fix a misspelling of kubernetes
ab83415
@dfinkel
go mod tidy
7234b40
sergiosalvatore
sergiosalvatore approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@sergiosalvatore sergiosalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dfinkel dfinkel merged commit ac486ab into master May 7, 2019
@dfinkel dfinkel deleted the vendor_gomod_cleanup branch May 7, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiosalvatore sergiosalvatore sergiosalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfinkel @sergiosalvatore