psalm cache bug with constructor property promotion

[ging-dev]

<?php

class Example
{
    public function __construct(private string $error)
    {
    }

    public function other(): string
    {
        return $this->error;
    }
}

run psalm with cache. After, change content to:

<?php

class Example
{
    public function __construct()
    {
    }

    public function other(): string
    {
        return $this->error;
    }
}

re-run psalm, psalm doesn't show an error message, but an error actually exists

[psalm-github-bot]

Hey @ging-dev, can you reproduce the issue on https://psalm.dev ?

[weirdan]

Can you provide a reproducer repo? I tried this in Psalm's own repo, and errors were reported.

[ging-dev]

Can you provide a reproducer repo? I tried this in Psalm's own repo, and errors were reported.

https://github.com/ging-dev/psalm-cache-reproduce

Here is video i reproduced it:

2023-08-03.16-26-34.mp4

[weirdan]

Relevant parts from the debug log:

$ vendor/bin/psalm --debug 
Process plugin adjustments...
Target PHP version: 8.2 (inferred from current PHP version).
Scanning files...
1 changed files:
    /home/weirdan/src/psalm/issues/psalm-cache-reproduce/src/Bug/Reproduce.php
[.....]
Parsing /home/weirdan/src/psalm/issues/psalm-cache-reproduce/src/Bug/Reproduce.php
Deep scanning /home/weirdan/src/psalm/issues/psalm-cache-reproduce/src/Bug/Reproduce.php
[.....]
Analyzing files...
Getting /home/weirdan/src/psalm/issues/psalm-cache-reproduce/src/Bug/Reproduce.php
Analyzing /home/weirdan/src/psalm/issues/psalm-cache-reproduce/src/Bug/Reproduce.php
Skipping analysis of pre-analyzed method App\Bug\Reproduce::error
[.....]

[weirdan]

Changes to __construct() should cause error() to be reanalyzed, and it should be triggered somewhere around here:

psalm/src/Psalm/Internal/Codebase/Analyzer.php

Lines 658 to 663 in c83b0c9

	if (isset($all_referencing_methods[$member_id])) {
	$newly_invalidated_methods = array_merge(
	$all_referencing_methods[$member_id],
	$newly_invalidated_methods,
	);
	}