NodeDataProvider empty in LSP

[joehoyle]

I have a custom plugin that makes use of the Psalm\Internal\Provider\NodeDataProvider for some custom return type logic via AfterFunctionCallAnalysisInterface.

As I understand it, afterFunctionCallAnalysis is passed an expression, where I'm looking at the type of the second param on a function call. That second param is of type PhpParser\Node\Name. afterFunctionCallAnalysis needs to provide return_type_candidate with a Union containing that type. However, the "type" I get from the FuncCall expression is the PhpParser type.

I had been using StatementsSource::getNodeTypeProvider::getType() which appears to be able to map a PhpParser expression or node name to a Psalm Type. This works well when running psalm from the command line.

However, when running via the LSP, it seems that the StatementsSource::getNodeTypeProvider->node_types is an empty SplObjectStorage object. Perhaps this is to do with how the file contents is passed to the LSP, and given (perhaps) that file is in memory rather than on-disk, then there's some different behavior where the current file does not appear to be tokenized (or something!).

Could anyone provide me some guidance on why the LSP behavior I'm seeing here is different from the Psalm CLI. Thanks!

[psalm-github-bot]

Hey @joehoyle, can you reproduce the issue on https://psalm.dev ?

[joehoyle]

No, I don’t believe I can include my custom plugin on psalm.dev

…

-- Joe Hoyle CTO Human Made

On Thu, Apr 23 2020 at 15:58, psalm-github-bot[bot] < ***@***.*** > wrote: Hey @joehoyle ( https://github.com/joehoyle ) , can you reproduce the issue on https://psalm.dev ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( #3216 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AABHPE6HC2XZHEO63TYRDBLROBCRHANCNFSM4MPCBNTQ ).

[muglug]

@joehoyle I'd use the (more-recently-added) FunctionReturnTypeProviderInterface to give Psalm return type suggestions for functions. You should find it simpler to use!

[joehoyle]

@muglug Thanks! I'll give that a go, will re-open if I see the same issue there.