Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify requirement phpdocumentor/reflection-docblock:^4.3.4 || ^5 #3967

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

sasezaki
Copy link
Contributor

@sasezaki sasezaki commented Aug 9, 2020

specify requirements for the sake of travis "low" deps fails.

ダウンロード (4)


"low" deps would install phpdocumentor/reflection-docblock with 4.0.0. but, reflection-docblock 4.0.0. has bug Uninitialized string offset: 0 .


  • Currently, psalm requirements "php": "^7.1.3|^8"
  • phpspec/prophecy:1.9.0, 1.10.0 requirements php:"^5.3|^7.0"
  • phpspec/prophecy:1.9.0, 1.10.0 requirements "phpdocumentor/reflection-docblock": "^2.0|^3.0.2|^4.0|^5.0",

But, prophecy upper version drop support php 7.1.

  • phpspec/prophecy:1.11.0 requirements php:"^7.2",
  • phpspec/prophecy:1.11.0 requirements "phpdocumentor/reflection-docblock": "^5.0",.
    and reflection-docblock:5 also requires "php": "^7.2"

So, specify requirement phpdocumentor/reflection-docblock:^4.3.4 || ^5 .

@sasezaki sasezaki marked this pull request as ready for review August 9, 2020 08:07
@muglug muglug merged commit 12cd512 into vimeo:master Aug 9, 2020
@muglug
Copy link
Collaborator

muglug commented Aug 9, 2020

Thanks!

@sasezaki sasezaki deleted the reflection-docblock_ver branch August 10, 2020 01:06
sasezaki added a commit to sasezaki/psalm that referenced this pull request Feb 9, 2022
…endency

see vimeo#3967
prophecy upper version always phpdocumentor/reflection-docblock:^5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants