New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isAlwaysTruthy: TNonEmptyString can be falsy (with '0') #6585

Merged

orklah merged 1 commit into vimeo:master from orklah:truthy

Oct 5, 2021

Collaborator

orklah commented Oct 4, 2021

This fixes a mistake. There is a value in TNonEmptyString that is falsy so we can't use it in isAlwaysTruthy.

I added TNonFalsyString (and TCallableString until #6521 can be merged)


          fix isAlwaysTruthy: TNonEmptyString can be falsy (with '0')

20bb5f1

weirdan approved these changes

View reviewed changes

orklah merged commit 2956220 into vimeo:master

weirdan added the release:fix label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels