Php version consistency #6898
Merged
Php version consistency #6898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
requested changes
Nov 12, 2021
Collaborator
weirdan
left a comment
weirdan
left a comment
There was a problem hiding this comment.
BC breaks look avoidable. Conversions from version ID to major/minor need to be fixed, and it would be better to move conversions into its own helper class.
src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallReturnTypeFetcher.php
Outdated
Show resolved
Hide resolved
src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodCallReturnTypeFetcher.php
Outdated
Show resolved
Hide resolved
...ternal/Analyzer/Statements/Expression/Call/StaticMethod/ExistingAtomicStaticCallAnalyzer.php
Outdated
Show resolved
Hide resolved
weirdan
added
the
release:deprecation
Collaborator
Author
|
I did not pursue this as a change in current version because I really hate the change in order to avoid the BC break. This will probably be something only in Psalm 5... |
Collaborator
I added the Psalm 5 milestone we can use for such PRs / issues. |
weirdan
added a commit
to weirdan/psalm
that referenced
this pull request
Jan 2, 2022
…rsion` properties Removed in vimeo#6898 (Psalm 5)
weirdan
added
release:removed
weirdan
approved these changes
Jan 2, 2022
Collaborator
|
@orklah mind giving this a once-over? I rebased it, removed deprecated properties and documented BC breaks (in |
Collaborator
Author
|
I'll take a look tonight |
Collaborator
Author
|
That seems correct. Thanks for the documentation and the rebase <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings consistency to the way we use php versions. Before that, sometimes we passed them under the X.Y format, sometimes as two int params and sometimes as an array of two ints...
It also get rid of those horrors:
and it fixes a couple of bugs like
if (\PHP_VERSION_ID < 80100 && $codebase->php_major_version >= 8 && $codebase->php_minor_version >= 1) {that would have been a problem in version 9.0
However, it's probably a BC break for plugin users...